Move docs home copy upstream and fix tutorial anchor#2671
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTop-level documentation was reworked: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR makes two focused documentation changes: it replaces the GitHub-navigation-centric Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Reader lands on docs/README.md] --> B{What describes you?}
B --> C[Starting a new app]
B --> D[Adding React to existing app]
B --> E[Already using OSS, evaluating Pro]
B --> F[Evaluating Rails + React options]
C --> C1[create-react-on-rails-app.md]
C --> C2[quick-start.md]
D --> D1[installation-into-an-existing-rails-app.md]
D --> D2[using-react-on-rails.md]
E --> E1[oss-vs-pro.md]
E --> E2[upgrading-to-pro.md]
F --> F1[reactonrails.com/examples]
F --> F2[comparison-with-alternatives.md]
F --> F3[migrating-from-react-rails.md]
A --> G[Dive deeper]
G --> G1[introduction.md]
G --> G2[how-react-on-rails-works.md]
G --> G3[view-helpers-api.md]
G --> G4[deployment/README.md]
A --> H[Need more help?]
H --> H1[GitHub Discussions]
H --> H2[reactonrails.com/docs/]
Last reviewed commit: "Move docs home copy ..." |
9369023 to
38740d5
Compare
ReviewAll internal links verified — every relative path in the new One usability concern: The previous README included a direct link to the Changelog ( Minor: Otherwise this is a clean, low-risk docs cleanup. The user-journey structure is clearer than the previous categorical index. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
38740d5 to
cca476a
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/README.md (1)
20-21: Consider consolidating duplicated “Upgrade to Pro” links.Line 20 and Line 41 both point to the same page. Keeping one primary CTA can reduce repetition in the landing flow.
Also applies to: 41-42
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/README.md` around lines 20 - 21, Remove the duplicated "[Upgrade to Pro]" link pointing to "./pro/upgrading-to-pro.md" so only one primary CTA remains; locate both occurrences of the link text "[Upgrade to Pro]" and the target "./pro/upgrading-to-pro.md" in README.md, keep the more context-appropriate instance (e.g., the primary landing CTA) and delete the other, ensuring surrounding copy still reads naturally and any list/spacing is adjusted accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/README.md`:
- Around line 20-21: Remove the duplicated "[Upgrade to Pro]" link pointing to
"./pro/upgrading-to-pro.md" so only one primary CTA remains; locate both
occurrences of the link text "[Upgrade to Pro]" and the target
"./pro/upgrading-to-pro.md" in README.md, keep the more context-appropriate
instance (e.g., the primary landing CTA) and delete the other, ensuring
surrounding copy still reads naturally and any list/spacing is adjusted
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4e82e695-eddf-40e8-9474-b398cc2de451
📒 Files selected for processing (2)
docs/README.mddocs/oss/getting-started/tutorial.md
✅ Files skipped from review due to trivial changes (1)
- docs/oss/getting-started/tutorial.md
Review: Move docs home copy upstream and fix tutorial anchorOverall this is a clean, low-risk docs restructuring. The tutorial anchor fix ( Strengths
Issues found (inline comments posted)
None are blocking — all are minor content gaps rather than errors. |
Address review feedback: restore the tutorial link in the getting-started section, add configuration docs to the dive-deeper section, and make "contact us" actionable with a mailto link. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for the walkthrough and summary. No action needed — this was an automated overview. |
|
Thanks for the review. The confidence assessment and link verification were helpful. No action items here — the concerns raised were addressed via the inline review comments. |
|
Both concerns from this review have been addressed:
|
|
All three issues from this review have been addressed in 2cc798e:
|
ReviewGood clean-up. The restructuring is clear and purposeful, and the anchor fix in the tutorial TOC is correct (whats-next matches the existing What's Next heading at line 255). One broken link found: docs/README.md line 36 links to ./oss/upgrading/changelog.md, but that file does not exist. The only file in docs/oss/upgrading/ is upgrading-react-on-rails.md. I left an inline suggestion on that line. Minor observations (no action required):
Otherwise LGTM -- documentation-only change with no runtime impact. |
## Summary - Stamp `### [16.5.0.rc.0]` version header with today's date - Add 10 new changelog entries for PRs merged since v16.4.0 - Fix incomplete PR 2818 entry (missing author link) ### New entries added **Added:** - `create-react-on-rails-app --pro` support (PR 2818) - Global prerender env override `REACT_ON_RAILS_PRERENDER_OVERRIDE` (PR 2816) - `react_on_rails:sync_versions` rake task (PR 2797) - Pro/RSC setup checks in `react_on_rails:doctor` (PR 2674) **Changed:** - [Pro] Canonical env var for worker count is now `RENDERER_WORKERS_COUNT` (PR 2611) **Improved:** - Smoother `create-react-on-rails-app` and install generator flows (PR 2650) - Pro upgrade hint after install (PR 2642) **Fixed:** - Preserve runtime env vars across `Bundler.with_unbundled_env` (PR 2836) - Fix doctor prerender check and ExecJS display for Pro/RSC apps (PR 2773) - Fix doctor false positives for custom layouts (PR 2612) ### Skipped PRs (not user-visible) Docs-only: #2845, #2842, #2826, #2830, #2820, #2809, #2803, #2785, #2801, #2791, #2789, #2788, #2772, #2778, #2780, #2784, #2671, #2676, #2662, #2657, #2669 CI/internal tooling: #2825, #2817, #2819, #2812, #2815, #2810, #2808, #2807, #2634, #2798, #2761, #2760, #2658, #2639, #2667, #2656 ## Test plan - [x] Verified version header and diff links are correct - [x] Verified all entries follow changelog formatting conventions - [x] Verified file ends with newline - [ ] After merge, run `rake release` to publish 16.5.0.rc.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only change updating `CHANGELOG.md` with a new `16.5.0.rc.0` section and compare links; no runtime code is modified. > > **Overview** > Adds a new `16.5.0.rc.0` (2026-03-25) section to `CHANGELOG.md`, consolidating recent PR entries under **Added/Changed/Improved/Fixed** and correcting the previously incomplete `--pro` CLI entry author attribution. > > Updates the bottom compare links so `[unreleased]` now compares from `v16.5.0.rc.0` and adds a link definition for `[16.5.0.rc.0]`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 481a71c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - v16.5.0.rc.0 * **New Features** * Added sync_versions task for streamlined version management * Expanded doctor checks for Pro and RSC support * **Improvements** * Enhanced generator workflow and Pro upgrade guidance * Improved environment variable handling and preservation * **Bug Fixes** * Fixed detection issues with doctor tools and ExecJS/prerender functionality <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Moves the canonical docs-home copy into `docs/README.md` so `reactonrails.com` no longer has to own that prose in `prepare-docs.mjs`. Also fixes the tutorial table-of-contents anchor so it points to the existing `What's Next?` section instead of the stale `#conclusion` anchor. - Replaces the generic docs README with the canonical docs landing content used by the site - Keeps the GitHub-friendly docs website link in the upstream README - Fixes `docs/oss/getting-started/tutorial.md` TOC link from `#conclusion` to `#whats-next` This is the remaining upstream/site-boundary cleanup from the docs work. The site repo should present docs, not own canonical docs content. - `reactonrails.com`: `npm run prepare` - `reactonrails.com`: `npm run build` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: documentation-only restructuring and link/anchor fixes with no runtime code changes. > > **Overview** > Updates `docs/README.md` from a GitHub navigation stub to a more opinionated docs landing page that explains OSS vs Pro, reorganizes entry points by user intent, and adds Pro evaluation/help links. > > Fixes the tutorial table-of-contents to link to the existing **“What’s Next?”** section (`#whats-next`) instead of a stale conclusion anchor. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2cc798e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Documentation** * Renamed top-level docs to "Documentation Guide" and reframed intro to present OSS vs Pro paths with selection criteria. * Reorganized navigation into path-oriented sections (new app, add-to-app, OSS→Pro evaluation) and consolidated deeper links. * Reduced main Pro feature listings, updated help links, and added a friendly evaluation policy. * Tutorial TOC anchor changed: "Conclusion" → "What's Next?" <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Moves the canonical docs-home copy into `docs/README.md` so `reactonrails.com` no longer has to own that prose in `prepare-docs.mjs`. Also fixes the tutorial table-of-contents anchor so it points to the existing `What's Next?` section instead of the stale `#conclusion` anchor. - Replaces the generic docs README with the canonical docs landing content used by the site - Keeps the GitHub-friendly docs website link in the upstream README - Fixes `docs/oss/getting-started/tutorial.md` TOC link from `#conclusion` to `#whats-next` This is the remaining upstream/site-boundary cleanup from the docs work. The site repo should present docs, not own canonical docs content. - `reactonrails.com`: `npm run prepare` - `reactonrails.com`: `npm run build` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: documentation-only restructuring and link/anchor fixes with no runtime code changes. > > **Overview** > Updates `docs/README.md` from a GitHub navigation stub to a more opinionated docs landing page that explains OSS vs Pro, reorganizes entry points by user intent, and adds Pro evaluation/help links. > > Fixes the tutorial table-of-contents to link to the existing **“What’s Next?”** section (`#whats-next`) instead of a stale conclusion anchor. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2cc798e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Documentation** * Renamed top-level docs to "Documentation Guide" and reframed intro to present OSS vs Pro paths with selection criteria. * Reorganized navigation into path-oriented sections (new app, add-to-app, OSS→Pro evaluation) and consolidated deeper links. * Reduced main Pro feature listings, updated help links, and added a friendly evaluation policy. * Tutorial TOC anchor changed: "Conclusion" → "What's Next?" <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Moves the canonical docs-home copy into
docs/README.mdsoreactonrails.comno longer has to own that prose inprepare-docs.mjs.Also fixes the tutorial table-of-contents anchor so it points to the existing
What's Next?section instead of the stale#conclusionanchor.Changes
docs/oss/getting-started/tutorial.mdTOC link from#conclusionto#whats-nextWhy
This is the remaining upstream/site-boundary cleanup from the docs work. The site repo should present docs, not own canonical docs content.
Validation
reactonrails.com:npm run preparereactonrails.com:npm run buildNote
Low Risk
Low risk: documentation-only restructuring and link/anchor fixes with no runtime code changes.
Overview
Updates
docs/README.mdfrom a GitHub navigation stub to a more opinionated docs landing page that explains OSS vs Pro, reorganizes entry points by user intent, and adds Pro evaluation/help links.Fixes the tutorial table-of-contents to link to the existing “What’s Next?” section (
#whats-next) instead of a stale conclusion anchor.Written by Cursor Bugbot for commit 2cc798e. This will update automatically on new commits. Configure here.
Summary by CodeRabbit