Document small-PR AI review workflow in AGENTS.md#2557
Conversation
WalkthroughDocumentation updated to include a new "Review Workflow" section in AGENTS.md, detailing guidelines for AI reviewer usage, review pacing, batching strategies, issue classification, and comment handling procedures. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review: Docs-only, low-riskThis is a clean, well-structured addition to One minor consistency issue: line 149 uses Everything else looks good — no code, test, or build impact. |
| - Treat as blocking only: correctness bugs, failing tests, regressions, and clear inconsistencies with adjacent code. Nits and style suggestions are optional unless a maintainer asks for them. | ||
| - Verify language, runtime, and library claims locally before changing code in response to AI review comments. | ||
| - Deduplicate repeated bot comments before acting on them. Fix the underlying issue once, then resolve the duplicates. | ||
| - Rebase or merge `master` once, near the end of the review cycle. For `CHANGELOG.md` conflicts, prefer resolving them as the final step before merge. |
There was a problem hiding this comment.
Minor inconsistency: the rest of this file (line 175) uses `main` or `master`, but here only `master` appears. Since the repo's default branch is main, consider:
| - Rebase or merge `master` once, near the end of the review cycle. For `CHANGELOG.md` conflicts, prefer resolving them as the final step before merge. | |
| - Rebase or merge `main` once, near the end of the review cycle. For `CHANGELOG.md` conflicts, prefer resolving them as the final step before merge. |
Greptile SummaryThis documentation-only PR inserts a new Review Workflow section into Key observations:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR opened] --> B{Small PR?\n≤5 files, one purpose}
B -- Yes --> C[Single AI reviewer\nleaves inline comments]
B -- No --> C2[No specific guidance\nin current doc]
C --> D[Wait for full\nreview pass]
D --> E[Classify comments:\nblocking / optional / noise]
E --> F[Apply blocking fixes\n+ selected optional items]
F --> G[Batch into one\nfollow-up push]
G --> H{CHANGELOG.md\nconflict?}
H -- Yes --> I[Resolve as final\nstep before merge]
H -- No --> J[Rebase / merge master\nonce near end of cycle]
I --> K[Merge]
J --> K
Last reviewed commit: 1db35f4 |
|
|
||
| ## Review Workflow | ||
|
|
||
| For small, focused PRs (roughly 5 files changed or fewer and one clear purpose): |
There was a problem hiding this comment.
Guidance gap for larger PRs
The entire section is scoped to "small, focused PRs (roughly 5 files changed or fewer)". This leaves agents without any guidance for PRs that exceed that threshold. Since most of the bullet points (batch fixes, triage blocking vs. optional, deduplicate bot comments, rebase once near the end) apply equally well to any PR size, consider either dropping the conditional or adding a separate paragraph for larger PRs.
| For small, focused PRs (roughly 5 files changed or fewer and one clear purpose): | |
| For all PRs — and especially small, focused ones (roughly 5 files changed or fewer with one clear purpose): |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| - Verify language, runtime, and library claims locally before changing code in response to AI review comments. | ||
| - Deduplicate repeated bot comments before acting on them. Fix the underlying issue once, then resolve the duplicates. | ||
| - Rebase or merge `master` once, near the end of the review cycle. For `CHANGELOG.md` conflicts, prefer resolving them as the final step before merge. | ||
| - When asking an agent to address review comments, instruct it to classify comments into `blocking`, `optional`, and `noise`, then apply only the `blocking` items plus any explicitly selected optional items. |
There was a problem hiding this comment.
Undefined classification categories
The terms blocking, optional, and noise are introduced here without a definition. Different agents or contributors may interpret these labels inconsistently, leading to divergent triage behavior. Consider adding a brief inline definition or a short legend, for example:
| - When asking an agent to address review comments, instruct it to classify comments into `blocking`, `optional`, and `noise`, then apply only the `blocking` items plus any explicitly selected optional items. | |
| - When asking an agent to address review comments, instruct it to classify comments into `blocking` (must fix before merge), `optional` (worth doing but not required), and `noise` (irrelevant, duplicate, or out-of-scope), then apply only the `blocking` items plus any explicitly selected optional items. |
## Summary - Add changelog entries for 6 user-visible PRs merged since v16.4.0.rc.6 that were missing from `[Unreleased]` - Update existing #2561 entry to include #2568 contributor credit ### New entries added | Section | PR | Description | |---|---|---| | Added | #2539 | Environment-variable-driven ports in Procfile templates | | Fixed | #2417 | Rspack generator config path fix | | Fixed | #2419 | Precompile hook load-based execution fix | | Fixed | #2577 | `create-react-on-rails-app` validation improvements | | Pro Fixed | #2416 | StreamResponse status fallback fix | | Pro Fixed | #2566 | Empty-string license plan mismatch fix | ### Skipped PRs (not user-visible) Docs (#2406, #2414, #2479, #2494, #2518, #2537, #2544), CI/internal (#2533, #2547, #2555, #2557, #2558, #2564), dependabot (#2387, #2541), dev dependencies (#2559, #2569, #2573). ## Test plan - [ ] Verify changelog formatting matches existing entries - [ ] Verify all user-visible PRs since v16.4.0.rc.6 are covered 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only changelog updates with no runtime or build behavior changes. > > **Overview** > Updates `CHANGELOG.md`’s **[Unreleased]** section to include previously missing user-facing entries: Procfile templates now support env-driven ports, several generator/`bin/dev` precompile-hook and rspack-path fixes are documented, and `create-react-on-rails-app` validation improvements are noted. > > Also adds two Pro fix entries (StreamResponse status fallback and license plan empty-string validation) and updates the existing `bin/dev` precompile-hook entry to credit an additional PR/contributor. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e75d2b5. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
AGENTS.mdmastersyncTest Plan
Note
Low Risk
Docs-only change with no runtime, build, or test impact.
Overview
Adds a new Review Workflow section to
AGENTS.mddocumenting how to handle small, focused PRs, including limiting inline AI reviewers, batching fixes after a full review pass, and triaging comments asblockingvsoptionalvsnoise.Also codifies guidance to verify AI claims locally, deduplicate bot comments, and delay syncing with
master(with a note onCHANGELOG.mdconflict resolution) until late in the review cycle.Written by Cursor Bugbot for commit 1db35f4. Configure here.
Summary by CodeRabbit