-
-
Notifications
You must be signed in to change notification settings - Fork 628
chore: add tracking plan for issue #2472 #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1f86662
chore: add tracking plan for issue #2472
justin808 d35db0a
docs: clarify tracking status and success criteria
justin808 ceaffce
docs: tighten race-condition tracking acceptance criteria
justin808 ea36d4b
docs: specify lock reversion target and new test-case scope
justin808 a461151
Tighten issue 2472 tracking success criteria
justin808 2b124cf
Clarify existing different-bundle coverage in plan
justin808 f68666a
Specify exact lock/unlock mutation target
justin808 c64a0d3
Clarify tracking status and temporary revert wording
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Issue #2472 Tracking Plan | ||
|
|
||
| - Issue: https://github.com/shakacode/react_on_rails/issues/2472 | ||
| - Title: Improve uploadRaceCondition.test.ts to verify truly concurrent asset writes | ||
| - Status: Draft tracking PR opened to coordinate implementation work while issue #2472 remains open. | ||
|
justin808 marked this conversation as resolved.
Outdated
|
||
|
|
||
| ## Plan | ||
|
|
||
| 1. Reproduce current test behavior and confirm where existing `addBarrier()` synchronization still allows serialized writes. | ||
|
justin808 marked this conversation as resolved.
Outdated
|
||
| 2. Update `uploadRaceCondition.test.ts` assertions to prove truly concurrent write paths and verify resilience under contention. | ||
| 3. Validate with focused test runs and update related test comments/documentation as needed. | ||
|
|
||
| ## Success Criteria | ||
|
|
||
| 1. `uploadRaceCondition.test.ts` fails without the race-condition fix and passes with it. | ||
| 2. The test asserts concurrent write behavior explicitly (not only eventual file correctness). | ||
|
justin808 marked this conversation as resolved.
Outdated
|
||
| 3. Focused local test run and CI job for the updated test both pass. | ||
|
justin808 marked this conversation as resolved.
Outdated
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.