Update Helper to Check for Bundle with correct Extension#1511
Merged
Update Helper to Check for Bundle with correct Extension#1511
Conversation
pulkitkkr
force-pushed
the
ROR1510-bug-fix-missing-pack-warning
branch
2 times, most recently
from
ea1769b to
f57a4e3
Compare
pulkitkkr
force-pushed
the
ROR1510-bug-fix-missing-pack-warning
branch
from
f57a4e3 to
51a86c3
Compare
pulkitkkr
force-pushed
the
ROR1510-bug-fix-missing-pack-warning
branch
from
51a86c3 to
5fb4f35
Compare
justin808
reviewed
Jan 26, 2023
| def generated_components_pack(component_name) | ||
| "#{ReactOnRails::WebpackerUtils.webpacker_source_entry_path}/generated/#{component_name}" | ||
| def generated_components_pack_path(component_name) | ||
| extension = PacksGenerator.generated_pack_extension |
Member
There was a problem hiding this comment.
Why is this customizable? Why not always .js?
Contributor
Author
There was a problem hiding this comment.
It's not configurable! It's always js
|
|
||
| *Please add entries here for your pull requests that are not yet released.* | ||
| - Added `./bin/dev` and `./bin/dev-static` executables to ease and standardize running the dev server. [PR 1491](https://github.com/shakacode/react_on_rails/pull/1491) by [ahangarha](https://github.com/ahangarha) | ||
| - Fixed pack not found warning while using `react_component` and `react_component_hash` helpers, even when corresponding chunks are present in `manifest` file [PR 1511](https://github.com/shakacode/react_on_rails/pull/1511) by [pulkitkkr](https://github.com/pulkitkkr) |
Member
There was a problem hiding this comment.
what does the manifest have to do with the changes?
Contributor
Author
There was a problem hiding this comment.
Updated it to:
Fixed pack not found warning while using `react_component` and `react_component_hash` helpers, even when corresponding chunks are present.
justin808
requested changes
Jan 27, 2023
| def generated_components_pack(component_name) | ||
| "#{ReactOnRails::WebpackerUtils.webpacker_source_entry_path}/generated/#{component_name}" | ||
| def generated_components_pack_path(component_name) | ||
| extension = PacksGenerator.generated_pack_extension |
Contributor
Author
|
Added Tests |
pulkitkkr
commented
Jan 27, 2023
Contributor
Author
pulkitkkr
left a comment
pulkitkkr
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Judahmeek and @justin808)
lib/react_on_rails/helper.rb line 112 at r1 (raw file):
Previously, justin808 (Justin Gordon) wrote…
Then why not a constant?
Done.
justin808
approved these changes
Jan 28, 2023
justin808
reviewed
Jan 28, 2023
|
|
||
| def generated_components_pack(component_name) | ||
| "#{ReactOnRails::WebpackerUtils.webpacker_source_entry_path}/generated/#{component_name}" | ||
| def generated_components_pack_path(component_name) |
Member
There was a problem hiding this comment.
Should this be part of the helper? or not?
Contributor
Author
There was a problem hiding this comment.
It should be a private member
justin808
reviewed
Jan 28, 2023
| @@ -94,8 +94,7 @@ def react_component(component_name, options = {}) | |||
| end | |||
|
|
|||
| def load_pack_for_component(component_name) | |||
Member
There was a problem hiding this comment.
why is this part of the public helper?
there's no doc for this method load_pack_for_component
or generated_components_pack_path
Contributor
Author
There was a problem hiding this comment.
It should be private member as it is used internally by react_component and react_component_hash
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 11, 2026
This was referenced Mar 21, 2026
This was referenced Mar 28, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug as described in the Issue: #1510
This change is