Skip to content

Upgrade Babel version to 7#1141

Merged
justin808 merged 2 commits intoshakacode:masterfrom
tricknotes:upgrade-to-babel-7
Sep 13, 2018
Merged

Upgrade Babel version to 7#1141
justin808 merged 2 commits intoshakacode:masterfrom
tricknotes:upgrade-to-babel-7

Conversation

@tricknotes
Copy link
Copy Markdown
Contributor

@tricknotes tricknotes commented Sep 12, 2018

This change has been suggested in #1140 .


This change is Reviewable

@tricknotes
Copy link
Copy Markdown
Contributor Author

Oops, some tests are failed :<
I'll check it later.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at ?% when pulling b3a75e1 on tricknotes:upgrade-to-babel-7 into e6e15c4 on shakacode:master.

@tricknotes tricknotes force-pushed the upgrade-to-babel-7 branch 3 times, most recently from 32a6366 to f0f8ed2 Compare September 12, 2018 16:14
@tricknotes tricknotes changed the title Upgrade Babel version to 7 [WIP] Upgrade Babel version to 7 Sep 12, 2018
@tricknotes tricknotes changed the title [WIP] Upgrade Babel version to 7 Upgrade Babel version to 7 Sep 12, 2018
Now we use `yarn.lock` instead.
@tricknotes
Copy link
Copy Markdown
Contributor Author

All tests are passed on Travis CI.

@justin808
Could you review this PR?

@justin808 justin808 merged commit dce1b20 into shakacode:master Sep 13, 2018
@justin808
Copy link
Copy Markdown
Member

Thank you @tricknotes! Merged. I'll release. I also invited you to https://shakacode.slack.com/

@tricknotes
Copy link
Copy Markdown
Contributor Author

Woot, great thanks!
Also thanks for your invitation! Now I joined ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants