CI skips build/type-check for react-on-rails-pro-node-renderer changes

[AbanoubGhadban]

Problem

Changes to packages/react-on-rails-pro-node-renderer/ do not trigger the pnpm build (which runs tsc) or type-check CI jobs. This allowed a TypeScript compilation error to be merged to master in PR #2456.

Root Cause

The change detection script (script/ci-changes-detector) has two issues:

1. Orphaned flag: The script correctly computes RUN_PRO_NODE_RENDERER_TESTS=true when node-renderer files change (line 288), but no workflow in .github/workflows/ references run_pro_node_renderer_tests — it is never consumed.

2. Missing condition: PRO_NODE_RENDERER_CHANGED is not included in the conditions for RUN_PRO_TESTS (line 280) or RUN_PRO_LINT (line 276), which are the flags that the pro-test-package-and-gem.yml and pro-lint.yml workflows actually gate on.

As a result, when a PR only touches files under packages/react-on-rails-pro-node-renderer/, the detect-changes job runs but all downstream build/test/lint jobs are SKIPPED.

Impact

• PR Fix node renderer upload race condition with per-request directories #2456 merged a TypeScript error (this type mismatch in worker.ts:170) that breaks pnpm build / pnpm install (since the prepare script runs tsc).
• Any future node-renderer-only PR will have the same blind spot — no type-checking, no build validation, no linting.

Suggested Fix

Either:

• Add PRO_NODE_RENDERER_CHANGED to the RUN_PRO_TESTS and RUN_PRO_LINT conditions in script/ci-changes-detector
• Or create a dedicated workflow that consumes the run_pro_node_renderer_tests flag and runs pnpm build + type-check + jest for the node-renderer package

[AbanoubGhadban]

Closing as duplicate of #2471, which covers the same root cause and suggested fix.