-
Notifications
You must be signed in to change notification settings - Fork 374
Pro RSC migration: tutorial on React on Rails Pro with a React Server Components demo #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5551af9
Pro RSC migration 1/3: swap gem and npm to react_on_rails_pro (#726)
ihabadham 767c513
Pro RSC migration 2/3: switch SSR to the Pro Node renderer on webpack…
ihabadham f1fa1d7
Pro RSC migration 3/3: React Server Components demo on webpack
ihabadham 227fd25
Drop trailing comma in server_components spec populated-comments fixture
ihabadham 4c2a3e9
Update README to document Pro and React Server Components
ihabadham 7b9093e
Fix ESLint failures surfaced on the base PR's first lint run
ihabadham d29de5f
Disable react/prop-types project-wide; drop dead PropTypes from Toggl…
ihabadham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # React on Rails Pro license (JWT token from https://pro.reactonrails.com/). | ||
| # Required in production; optional in development/test. | ||
| REACT_ON_RAILS_PRO_LICENSE= | ||
|
|
||
| # Shared secret between Rails and the Node renderer. Must match on both sides. | ||
| # Dev/test default to `local-dev-renderer-password` if unset; production must | ||
| # set this explicitly (Pro raises at boot otherwise). | ||
| RENDERER_PASSWORD= | ||
|
|
||
| # Node renderer endpoint. Defaults to http://localhost:3800. | ||
| # RENDERER_URL=http://localhost:3800 | ||
|
|
||
| # Port the Node renderer listens on. Defaults to 3800. | ||
| # RENDERER_PORT=3800 | ||
|
|
||
| # Log verbosity for the Node renderer (debug, info, warn, error). | ||
| # Defaults to info. | ||
| # RENDERER_LOG_LEVEL=info | ||
|
|
||
| # Number of renderer worker processes. `0` is single-process mode, useful | ||
| # for local debugging. Defaults to 3; the app's CI workflow caps to 2. | ||
| # RENDERER_WORKERS_COUNT=3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <%= stream_react_component("ServerComponentsPage", | ||
| props: { comments: @server_components_comments }, | ||
| prerender: true, | ||
| auto_load_bundle: true, | ||
| trace: Rails.env.development?) %> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.