Skip to content

Staging apps via github actions - #579

Merged
justin808 merged 17 commits into
masterfrom
justin808-staging-apps
Jan 5, 2024
Merged

Staging apps via github actions#579
justin808 merged 17 commits into
masterfrom
justin808-staging-apps

Conversation

@justin808

@justin808 justin808 commented Dec 30, 2023

Copy link
Copy Markdown
Member

This change is Reviewable

@justin808
justin808 force-pushed the justin808-staging-apps branch from f7308cb to e3648a2 Compare January 4, 2024 08:05
@justin808
justin808 force-pushed the justin808-staging-apps branch from 8d73df6 to e5c83d7 Compare January 5, 2024 00:50
Comment thread .controlplane/Dockerfile
COPY --from=build /usr/local/bundle /usr/local/bundle
COPY --from=build /app /app

RUN chmod +x /app/.controlplane/*.sh

@justin808 justin808 Jan 5, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borela is this typical? Without, the file permissions were unset.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the files were committed to the repo without +x permission, you can fix that, commit the files again, and remove that chmod.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did and it didn't fix the issue.

@justin808 justin808 changed the title Justin808 staging apps Staging apps via github actions Jan 5, 2024
@justin808
justin808 merged commit 3e4d754 into master Jan 5, 2024
@justin808
justin808 deleted the justin808-staging-apps branch January 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants