[FEATURE] binning_directory - #920
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 97.63% 97.65% +0.02%
==========================================
Files 235 236 +1
Lines 8908 9005 +97
==========================================
+ Hits 8697 8794 +97
Misses 211 211
Continue to review full report at Codecov.
|
eseiler
force-pushed
the
feature/binning_directory
branch
2 times, most recently
from
April 23, 2019 12:29
f4c55c7 to
b77dd42
Compare
eseiler
force-pushed
the
feature/binning_directory
branch
3 times, most recently
from
May 7, 2019 13:41
59fc34d to
9509b92
Compare
eseiler
force-pushed
the
feature/binning_directory
branch
3 times, most recently
from
May 17, 2019 16:24
cb2762c to
bbb625b
Compare
smehringer
requested changes
May 21, 2019
eseiler
force-pushed
the
feature/binning_directory
branch
2 times, most recently
from
June 20, 2019 13:30
004bc29 to
94885ed
Compare
eseiler
force-pushed
the
feature/binning_directory
branch
from
June 21, 2019 05:20
94885ed to
3c92278
Compare
smehringer
requested changes
Jul 2, 2019
smehringer
left a comment
smehringer
left a comment
Member
There was a problem hiding this comment.
Just some stuff I came across when scanning the code to evaluate if mitra can use it already.
eseiler
force-pushed
the
feature/binning_directory
branch
from
August 30, 2019 11:25
3c92278 to
20fe7e5
Compare
smehringer
requested changes
Jan 15, 2020
smehringer
reviewed
Jan 21, 2020
eseiler
force-pushed
the
feature/binning_directory
branch
from
January 24, 2020 06:53
20fe7e5 to
ab210b7
Compare
MitraDarja
requested changes
Jan 27, 2020
MitraDarja
reviewed
Feb 4, 2020
eseiler
force-pushed
the
feature/binning_directory
branch
from
February 11, 2020 12:20
04fb9c4 to
ba3680e
Compare
eseiler
commented
Feb 11, 2020
MitraDarja
requested changes
Feb 12, 2020
MitraDarja
left a comment
MitraDarja
left a comment
Contributor
There was a problem hiding this comment.
Looks goods, just some small things. :)
smehringer
requested changes
Feb 18, 2020
eseiler
force-pushed
the
feature/binning_directory
branch
from
February 19, 2020 09:13
9156803 to
58223ca
Compare
eseiler
commented
Feb 19, 2020
smehringer
requested changes
Feb 20, 2020
smehringer
left a comment
smehringer
left a comment
Member
There was a problem hiding this comment.
only tiny 💅 and then we can check the hash function once I have some tests on the uniformity
eseiler
force-pushed
the
feature/binning_directory
branch
from
February 25, 2020 08:33
339c607 to
d3c9167
Compare
smehringer
requested changes
Feb 25, 2020
smehringer
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by
#933Resolves #1562
TODO:
Debug streaming