Skip to content

[FEATURE] Technical Binning Directory - #1911

Closed
eseiler wants to merge 4 commits into
seqan:masterfrom
eseiler:feature/binning_directory
Closed

[FEATURE] Technical Binning Directory#1911
eseiler wants to merge 4 commits into
seqan:masterfrom
eseiler:feature/binning_directory

Conversation

@eseiler

@eseiler eseiler commented Jun 14, 2020

Copy link
Copy Markdown
Member

Resolves seqan/product_backlog#36

Open:

  • Introduce view_adaptor_for<adaptor_t, range_t>? ( requires(range_t range, adaptor_t adaptor) { {range | adaptor} -> std::ranges::view } )
  • simplify template arguments for compressed version (own class?, solve via config?)

Follow-up (?):

  • Multithreading for the ctor. Each thread can handle wordsize many bins (otherwise there may be concurrent write access to a memory position).

Comment thread include/seqan3/search/dream_index/technical_binning_directory.hpp Outdated
@eseiler
eseiler force-pushed the feature/binning_directory branch 2 times, most recently from 60c3fd4 to 12f5e14 Compare June 21, 2020 14:01
@eseiler
eseiler force-pushed the feature/binning_directory branch 2 times, most recently from d328408 to 7e1b217 Compare June 28, 2020 15:23
@eseiler
eseiler force-pushed the feature/binning_directory branch from 3b35cec to 96ecf5f Compare November 17, 2020 13:03
@codecov

codecov Bot commented Nov 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1911 (7695d77) into master (e7e0430) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         264      264           
  Lines       10784    10784           
=======================================
  Hits        10591    10591           
  Misses        193      193           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e0430...43f1830. Read the comment docs.

@eseiler
eseiler force-pushed the feature/binning_directory branch 2 times, most recently from 4c62d15 to a739283 Compare January 22, 2021 12:48
@eseiler
eseiler force-pushed the feature/binning_directory branch from a739283 to 6ffef1f Compare February 3, 2021 16:16
@eseiler
eseiler force-pushed the feature/binning_directory branch 2 times, most recently from 6ffef1f to c35e43b Compare February 3, 2021 16:26
@eseiler
eseiler force-pushed the feature/binning_directory branch from 09343b0 to 43f1830 Compare February 9, 2021 12:10
@eseiler

eseiler commented Feb 10, 2021

Copy link
Copy Markdown
Member Author

Core meeting 20-2-2021

  • The IBF will get a function count_values(query_kmers) and the counting_agent
  • The technical_binning_directory (TBD) will have the function count_query(query) that delegates to count_values in the IBF.
  • The TBD will not be part of the library just yet. It may remain just a cook book entry.

@eseiler

eseiler commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

Since we will solve this differently, I'll close this PR for now.

@eseiler eseiler closed this Mar 5, 2021
@eseiler
eseiler deleted the feature/binning_directory branch May 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IBF] seqan3::binning_directory

3 participants