Skip to content

chore: update szerror.py and bump version to 4.1.2 (#491) - #493

Merged
docktermj merged 2 commits into
mainfrom
491-docktermj-1
May 7, 2026
Merged

chore: update szerror.py and bump version to 4.1.2 (#491)#493
docktermj merged 2 commits into
mainfrom
491-docktermj-1

Conversation

@docktermj

@docktermj docktermj commented May 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sync src/senzing/szerror.py with upstream senzing-garage/sz-sdk-errors/python/szerror.py (regenerated date plus message updates for EAS_ERR_RETRY_TIMEOUT and EAS_ERR_XLITERATOR_FAILED).
  • Bump version 4.1.14.1.2 in pyproject.toml.
  • Add [4.1.2] - 2026-05-07 section to CHANGELOG.md.

Closes #491

Test plan

  • make lint
  • make clean setup test

Resolves #491

@docktermj
docktermj requested a review from a team as a code owner May 7, 2026 13:36
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

🤖 Claude Code Review

PR Code Review

Code Quality

Code follows style guide — The changes are minimal and consistent with existing patterns.

No commented-out code — No commented-out code introduced.

Meaningful variable names — N/A for this diff; no new variables introduced.

DRY principle followed — N/A; no duplication introduced.

Defects / bugs / edge cases — No logic bugs. The two error message updates in szerror.py (lines 160 and 473) are comment-only changes clarifying error string templates — no functional behavior changes.

⚠️ Minor: blank line removedszerror.py line 6: a blank line after the closing """ of the module docstring was removed. This is a trivial style nit but the file is auto-generated (DO NOT EDIT), so it should not be manually adjusted.

CLAUDE.md — No concerns; the project-level CLAUDE.md contains no environment-specific content.


Testing

Unit/integration tests — This is a version bump + auto-generated error mapping update. No new functions or endpoints were added; no new tests required.

Edge cases — N/A for this change.

Coverage — Existing coverage unaffected.


Documentation

CHANGELOG.md updated — Entry added for 4.1.2 with date 2026-05-07 and a description of the change.

⚠️ CHANGELOG.md description is vague"Updated szerror.py" doesn't explain what changed (two error message templates updated with additional context parameters). Consider: "Updated error message templates for EAS_ERR_RETRY_TIMEOUT and EAS_ERR_XLITERATOR_FAILED to include additional context parameters". Not a blocker, but improves traceability.

No API doc changes needed — The public API surface is unchanged.

Markdown formatting — CHANGELOG follows existing format; no extra whitespace issues detected.


Security

No hardcoded credentials — None present.

Input validation — N/A.

Error handling — Unchanged.

No sensitive data in logs — N/A.

No license files (.lic) — None present.


Summary

Category Status
Code Quality ✅ (minor nit on blank line in auto-generated file)
Testing
Documentation ⚠️ (CHANGELOG description could be more specific)
Security

Verdict: Approved with minor suggestions. The two items flagged are non-blocking — the blank line removal is in an auto-generated file and shouldn't be touched manually, and the CHANGELOG description, while vague, is functionally acceptable. No defects found.

Automated code review analyzing defects and coding standards

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/senzing
  szengineflags.py
  szerror.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

🤖 Claude Code Review

PR Code Review

Code Quality

Code style — Changes are minimal and consistent with existing patterns.

No commented-out code — Only inline comments in the error map, which serve as documentation of the original error strings. These are intentional.

Meaningful variable names — Not applicable; no new variables introduced.

DRY principle — No duplication introduced.

Defects / bugs — No logic errors. The two changed lines are comment strings that document error message formats (not code logic). The error class mappings themselves are unchanged.

CLAUDE.md — Project CLAUDE.md is appropriately general (no local-environment-specific paths beyond the standard /opt/senzing/er/lib Senzing install path, which is a documented prerequisite).


Testing

Unit/integration tests — No behavioral code was changed; only error message string documentation in comments was updated. No new tests required.

Coverage — Not impacted.


Documentation

CHANGELOG.md updated — Entry added for [4.1.2] - 2026-05-07.

⚠️ CHANGELOG entry is vague"Updated szerror.py" at line 17 doesn't describe what changed (updated error message format strings for error codes 10 and 7426). Consider: "Updated error message format strings for EAS_ERR_RETRY_TIMEOUT and EAS_ERR_XLITERATOR_FAILED". Minor, non-blocking.

API docs — No public API surface changed.

Markdown formatting — CHANGELOG follows the existing format consistently.


Security

No hardcoded credentials — None present.

No license files — No .lic files or AQAAAD-prefixed strings.

Input validation / error handling — Not applicable to this change.

No sensitive data — The updated error message templates (WORK_RETRY_TIMEOUT={1}s and Transliteration failed: {0}) expose only operational timing and transliteration input context, which is appropriate for diagnostic error messages.


Summary

This is a clean, low-risk version bump. The only suggestion is making the CHANGELOG entry more descriptive. Everything else looks correct.

Automated code review analyzing defects and coding standards

@docktermj docktermj self-assigned this May 7, 2026
@docktermj
docktermj merged commit e214832 into main May 7, 2026
81 checks passed
@docktermj
docktermj deleted the 491-docktermj-1 branch May 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update szerror.py

2 participants