Skip to content

Date objects fail json serialization#92

Merged
f2prateek merged 1 commit into
segmentio:masterfrom
hadrien:fix/date-objects-fail-json-serialization
Jan 25, 2017
Merged

Date objects fail json serialization#92
f2prateek merged 1 commit into
segmentio:masterfrom
hadrien:fix/date-objects-fail-json-serialization

Conversation

@hadrien

@hadrien hadrien commented Jan 23, 2017

Copy link
Copy Markdown
Contributor

Fix #91

@alexissmirnov

Copy link
Copy Markdown

+1

@hadrien

hadrien commented Jan 25, 2017

Copy link
Copy Markdown
Contributor Author

Who should/can review this @jgershen? Thanks!

@f2prateek

Copy link
Copy Markdown
Contributor

Sorry for the delay, this looks good to me! Would love to have @jgershen and/or @calvinfo review as well.

@calvinfo

Copy link
Copy Markdown
Contributor

LGTM! Thanks both of you!

@f2prateek f2prateek merged commit 4c9791d into segmentio:master Jan 25, 2017
@hadrien

hadrien commented Jan 25, 2017

Copy link
Copy Markdown
Contributor Author

Excellent!
How much time should we expect before release?

Sorry to push forward and thanks a lot for the support!

@f2prateek

Copy link
Copy Markdown
Contributor

I'll likely br able to release this sometime next week.

@hadrien hadrien deleted the fix/date-objects-fail-json-serialization branch January 30, 2017 19:12
@hadrien

hadrien commented May 8, 2017

Copy link
Copy Markdown
Contributor Author

Please, can you release the v1.2.7? I am looking forward it ! ;-) Thanks a lot!

@hadrien

hadrien commented May 8, 2017

Copy link
Copy Markdown
Contributor Author

It is actually released: https://pypi.python.org/pypi/analytics-python/1.2.7

My bad sorry! thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants