Skip to content

Fix validation when there’s no name of view controller - #730

Merged
f2prateek merged 1 commit into
segmentio:devfrom
Busta117:fix/no-title-on-viewcontroller
Nov 20, 2017
Merged

Fix validation when there’s no name of view controller#730
f2prateek merged 1 commit into
segmentio:devfrom
Busta117:fix/no-title-on-viewcontroller

Conversation

@Busta117

Copy link
Copy Markdown
Contributor

fixing issue number 729

app was crashing when recordScreenViews is true and try to report a screen with no name (like UIAlertController) and the validation was failing because [top title] returns an empty string instead of nil, so, validation was only with nil, i add the empty validation to get the name of the class

@codecov-io

codecov-io commented Nov 20, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (dev@18ef0c9). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             dev     #730   +/-   ##
======================================
  Coverage       ?   72.58%           
======================================
  Files          ?       39           
  Lines          ?     1638           
  Branches       ?      176           
======================================
  Hits           ?     1189           
  Misses         ?      330           
  Partials       ?      119

@f2prateek
f2prateek merged commit 17a59c4 into segmentio:dev Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants