Optimize PropertyDescriptor with flags#495
Merged
sebastienros merged 3 commits intoApr 16, 2018
Merged
Conversation
* optimize methods and make tweak for better inlining * use flags enum for PropertyDescriptor * remove Get and Set backing fields from PropertyDescriptor, separate GetSetPropertyDescriptor
… memory efficient PropertyDescriptor
lahma
force-pushed
the
perf/optimize-array-instance
branch
from
April 16, 2018 17:51
99ecd09 to
b3b282d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get more performance with no need to do interface dispatch for common property descriptor properties. Some memory penalty but the speed increase should be worth it - can check later on can we reduce memory usage without sacrificing speed.
Esprima.Benchmark.DromaeoBenchmark
Jint.Benchmark.ArrayBenchmark
Jint.Benchmark.ArrayStressBenchmark
Jint.Benchmark.UncacheableExpressionsBenchmark