feat: expose the negotiated TLS version via TlsInfo - #3067
Merged
seanmonstar merged 1 commit intoJul 13, 2026
Conversation
`TlsInfo` already carried the peer certificate and was already gated behind `ClientBuilder::tls_info(true)`, but the negotiated protocol version -- which the rustls backend has in hand at the point `TlsInfo` is built -- was never surfaced. `Response::version()` answers "which HTTP version?"; there was no equivalent for TLS. Add a `version` field to `TlsInfo` with a `version()` accessor, and populate it in the rustls `TlsInfoFactory` impls from `CommonState::protocol_version()`, translated through the existing `Version::from_rustls`. native-tls exposes no accessor for the negotiated version, so it reports `None` -- the same "`Some` where the backend can report it, `None` otherwise" contract `peer_certificate()` already has. Non-breaking: `TlsInfo`'s fields are `pub(crate)`, so downstream code can neither construct it with a struct literal nor match it exhaustively. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rpgnpy35JSnyLi9uHZ96hc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3066
TlsInfoalready carried the peer certificate and was already gated behindClientBuilder::tls_info(true), but the negotiated protocol version -- which the rustls backend has in hand at the pointTlsInfois built -- was never surfaced.Response::version()answers "which HTTP version?"; there was no equivalent for TLS.Add a
versionfield toTlsInfowith aversion()accessor, and populate it in the rustlsTlsInfoFactoryimpls fromCommonState::protocol_version(), translated through the existingVersion::from_rustls.native-tls exposes no accessor for the negotiated version, so it reports
None-- the same "Somewhere the backend can report it,Noneotherwise" contractpeer_certificate()already has.Non-breaking:
TlsInfo's fields arepub(crate), so downstream code can neither construct it with a struct literal nor match it exhaustively.