ci: add review criteria for the shared review skill - #7
Merged
Conversation
The reusable review workflow runs the `/review-pr` skill from the Scality agent hub, which reads its criteria from `.claude/REVIEW.md`. Without that file the review is generic and the skill says so in its own summary. Write the criteria instead of forking the skill into the repo: the skill keeps its posting mechanism and its updates, and this file stays a plain description of what matters here — the contract between the agent and the package, hostile archive input, crash safety, CRD and label compatibility, EL8/EL9 parity — plus the list of findings the linters already own.
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable review workflow runs the
/review-prskill from the Scality agenthub. That skill reads its criteria from
.claude/REVIEW.md, and when the file ismissing it says so in its own summary:
This adds the file rather than forking the skill into the repo. The skill keeps
its own posting mechanism and its upstream updates, and this file stays a plain
description of what matters here:
in the agent, in the package and in
agent/DESIGN.mdat onceown row
already own
The criteria mention
agent/, which lands with #4. Merging this first only meansthe agent rows apply a few days early.
Side effect worth noting: this PR is also the first real exercise of the app-key
pass-through merged in #6. It does not touch
review.yaml, so the workflowvalidation gate passes and the review should actually run — which #6 itself could
not demonstrate.