Skip to content

fix(instance): add support for listing all servers in scaleway_instance_servers data source - #4190

Open
remyleone wants to merge 1 commit into
scaleway:mainfrom
remyleone:instance_servers
Open

fix(instance): add support for listing all servers in scaleway_instance_servers data source#4190
remyleone wants to merge 1 commit into
scaleway:mainfrom
remyleone:instance_servers

Conversation

@remyleone

Copy link
Copy Markdown
Member

…ce_servers data source

Copilot AI review requested due to automatic review settings July 9, 2026 14:13
@remyleone
remyleone requested a review from a team as a code owner July 9, 2026 14:13
@remyleone remyleone changed the title fix(instance): add support for listing all servers in scaleway_instan… fix(instance): add support for listing all servers in scaleway_instance_servers data source Jul 9, 2026
estellesoulard
estellesoulard previously approved these changes Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR updates the scaleway_instance_servers data source to return the full set of servers (not just the first page) by enabling automatic pagination.

Changes:

  • Enable fetching all pages when listing instance servers via the Scaleway SDK.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/services/instance/servers_data_source.go
@github-actions github-actions Bot added the instance Instance issues, bugs and feature requests label Jul 9, 2026
@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 1.99%. Comparing base (2d0bc47) to head (edfa7c9).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/instance/servers_data_source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4190   +/-   ##
=====================================
  Coverage   1.99%   1.99%           
=====================================
  Files        589     589           
  Lines      67437   67437           
=====================================
  Hits        1346    1346           
  Misses     65991   65991           
  Partials     100     100           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

pypaut
pypaut previously requested changes Jul 29, 2026
Comment thread internal/services/instance/servers_data_source.go
@remyleone
remyleone dismissed pypaut’s stale review August 10, 2026 13:42

Creating 51 servers just to test this line does not seem to be appropriate in this context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants