Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions challenge7/gateway/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"eg": "./bin/index.js"
},
"dependencies": {
"bcrypt": "1.0.0",
"bcrypt": "5.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The update of bcrypt to version 5.0.1 introduces a critical incompatibility. This version requires Node.js v10 or higher, but the project's Dockerfile specifies node:8-alpine. This incompatibility will cause npm install to fail. To resolve this, you must either upgrade the project's Node.js environment or use a version of bcrypt that is compatible with Node.js 8 and also patches any relevant vulnerabilities.

"bluebird": "3.5.0",
"body-parser": "1.17.2",
"chalk": "1.1.3",
Expand All @@ -59,7 +59,7 @@
"glob": "7.1.2",
"http-proxy": "1.16.2",
"js-yaml": "3.8.3",
"lodash": "4.17.4",
"lodash": "4.17.23",
"minimatch": "3.0.3",
"node-uuid": "1.4.8",
"oauth2orize": "1.8.0",
Expand All @@ -74,8 +74,8 @@
"vhost": "3.0.2",
"winston": "2.3.1",
"yargs": "8.0.2",
"yeoman-environment": "2.0.0",
"yeoman-generator": "1.1.1"
"yeoman-environment": "3.0.0",
"yeoman-generator": "5.0.0"
Comment on lines +77 to +78

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The major version upgrades for yeoman-environment (to 3.0.0) and yeoman-generator (to 5.0.0) are incompatible with the project's current Node.js version. Both packages require Node.js v10.13.0 or higher, while the Dockerfile is configured to use node:8-alpine. This will break the build. To fix this, you need to either upgrade the Node.js environment for the entire project or find versions of these packages that are compatible with Node.js 8 and resolve the underlying security vulnerabilities.

},
"devDependencies": {
"chai": "3.5.0",
Expand Down