Add a method to expose whether the stream is positioned at the end of a BGZF block. - #522
Merged
Merged
Conversation
Contributor
|
👍 from me but I'd 👍 it even more if there was a test (this class has actually no tests so adding even 1 would be huge) |
tomwhite
force-pushed
the
expose-end-of-block-for-bgzf
branch
from
March 11, 2016 15:10
60f60d6 to
e595f61
Compare
Contributor
Author
|
Thanks @akiezun. I've added a test for this now. |
Contributor
|
LGTM - if there are no objections, I'll merge in 1 day |
akiezun
added a commit
that referenced
this pull request
Mar 14, 2016
Add a method to expose whether the stream is positioned at the end of a BGZF block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a method to BlockCompressedInputStream to expose whether the stream is positioned at the end of a BGZF block. This is needed by Hadoop-BAM (and GATK4 indirectly via its dependency on Hadoop-BAM) to add support for reading block compressed VCF files in parallel. See HadoopGenomics/Hadoop-BAM#68 and HadoopGenomics/Hadoop-BAM#70. /cc @akiezun
Checklist