Skip to content

feat: add EIP-3779 shortname for appchain - #1072

Closed
emrme wants to merge 2 commits into
safe-global:mainfrom
emrme:main
Closed

feat: add EIP-3779 shortname for appchain#1072
emrme wants to merge 2 commits into
safe-global:mainfrom
emrme:main

Conversation

@emrme

@emrme emrme commented Dec 10, 2024

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@emrme

emrme commented Dec 10, 2024

Copy link
Copy Markdown
Author

@yagopv @DaniSomoza pls approve

@yagopv

yagopv commented Dec 11, 2024

Copy link
Copy Markdown
Member

Hey @emrme. The config file in this repo is generated from the safe-deployments repo

Take a look to this doc page

A similar PR should be like this one

Once the safe-deployments package is released with your chain then we can update the SDK

@emrme

emrme commented Dec 11, 2024

Copy link
Copy Markdown
Author

Hey @yagopv, my PRs to safe-deployments repo are all merged already:

safe-global/safe-deployments#916
safe-global/safe-deployments#915
safe-global/safe-deployments#918
safe-global/safe-deployments#914

So now you are waiting for npm package release I guess?

@yagopv

yagopv commented Dec 11, 2024

Copy link
Copy Markdown
Member

So now you are waiting for npm package release I guess?

Yes, this will be included in the next protocol-kit release. Probably next week

@yagopv

yagopv commented Dec 12, 2024

Copy link
Copy Markdown
Member

Hey @emrme, a new version (v5.1.1) was published containing appchain networks. Thanks!

@yagopv yagopv closed this Dec 12, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants