Skip to content

Fix the actions enclosed in quotes are not updated#106

Merged
saadmk11 merged 2 commits intosaadmk11:mainfrom
kenz:fix/ignored_action_with_quotation
Sep 7, 2024
Merged

Fix the actions enclosed in quotes are not updated#106
saadmk11 merged 2 commits intosaadmk11:mainfrom
kenz:fix/ignored_action_with_quotation

Conversation

@kenz
Copy link
Copy Markdown
Contributor

@kenz kenz commented Jun 25, 2024

Fixed regular expressions to support quoted action names.

Related Issues #94

Demo

Original action file

PullRequest created by Original version Github Actions Updater

Quoted actions are not updated.

+      - uses: actions/checkout@v4.1.7
      - name: Without quotation
+        uses: actions/setup-node@v4.0.2

      - name: With single quotation
        uses: 'actions/setup-node@v3.0.0'

      - name: With double quotation
        uses: "actions/setup-node@v3.0.0"

https://github.com/kenz/github-action-updater-demo/pull/10/files

PullRequest created by supports quotation Version Github Actions Updater

Quoted actions also updated.

+      - uses: actions/checkout@v4.1.7
      - name: Without quotation
+        uses: actions/setup-node@v4.0.2

      - name: With single quotation
+        uses: 'actions/setup-node@v4.0.2'

      - name: With double quotation
+        uses: "actions/setup-node@v4.0.2"

https://github.com/kenz/github-action-updater-demo/pull/11/files

@kenz kenz changed the title Actions enclosed in quotes are also included in the update target. Re… Fix the actions enclosed in quotes are not updated Jun 25, 2024
Copy link
Copy Markdown
Owner

@saadmk11 saadmk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. 🚀

@saadmk11 saadmk11 merged commit ef9573d into saadmk11:main Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants