Skip to content

Device support of the Xiaomi Air Humidifier - #66

Merged
rytilahti merged 2 commits into
rytilahti:masterfrom
syssi:feature/humidifier
Sep 8, 2017
Merged

Device support of the Xiaomi Air Humidifier#66
rytilahti merged 2 commits into
rytilahti:masterfrom
syssi:feature/humidifier

Conversation

@syssi

@syssi syssi commented Sep 8, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread mirobo/discovery.py
"zhimi-airpurifier-v6": AirPurifier,
"chuangmi-ir-v2": ChuangmiIr,
# "zhimi-humidifier-v1": Humidifier,
"zhimi-humidifier-v1": AirHumidifier,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'AirHumidifier'

@coveralls

coveralls commented Sep 8, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.0%) to 34.016% when pulling cf03ad8 on syssi:feature/humidifier into adfa737 on rytilahti:master.

@rytilahti

Copy link
Copy Markdown
Owner

Thanks, looks like there is quite a bit of shared features between the devices, maybe this can be refactored later on somehow..

@rytilahti
rytilahti merged commit a4d85a1 into rytilahti:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants