Skip to content

Add support for SmartMi Zhimi Heaters - #625

Merged
rytilahti merged 8 commits into
rytilahti:masterfrom
bazuchan:heater
Feb 13, 2020
Merged

Add support for SmartMi Zhimi Heaters#625
rytilahti merged 8 commits into
rytilahti:masterfrom
bazuchan:heater

Conversation

@bazuchan

@bazuchan bazuchan commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Adds support for the following new devices:

  • Smartmi Radiant Heater Smart Version (ZA1 version)
  • Xiaomi Mi Smart Space Heater

Closes #615

@coveralls

coveralls commented Feb 10, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 74.044% when pulling bcd5769 on bazuchan:heater into ba8d1bb on rytilahti:master.

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me, left a couple of comments inline.

Please also update the device list in README.md.

Comment thread miio/heater.py Outdated
Comment thread miio/heater.py

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stylistic changes to improve readability & update to the README.md are the remaining tasks before getting this merged.

Comment thread miio/heater.py
Comment thread miio/heater.py
Comment thread miio/heater.py
Comment thread miio/heater.py
Comment thread miio/heater.py
@bazuchan

Copy link
Copy Markdown
Contributor Author

Some minor stylistic changes to improve readability & update to the README.md are the remaining tasks before getting this merged.

Done. Device names in README as in MiHome App (Market names way too different and confusing).

BTW ZA2 model seems to support only miot protocol.

@rytilahti rytilahti changed the title Add SmartMi Zhimi Heaters Add support for SmartMi Zhimi Heaters Feb 13, 2020
@rytilahti

Copy link
Copy Markdown
Owner

One last thing, could you also update discovery.py accordingly. I added a note about za2 to #627, thanks!

@bazuchan

Copy link
Copy Markdown
Contributor Author

One last thing, could you also update discovery.py accordingly.

Done

@rytilahti
rytilahti merged commit b905757 into rytilahti:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Smartmi Radiant Heater Smart Version (zhimi.heater.za2)

3 participants