Skip to content

Xiaomi Power Strip V1 is unable to handle some V2 properties - #303

Merged
syssi merged 5 commits into
rytilahti:masterfrom
syssi:feature/powerstrip-v1-properties
Apr 8, 2018
Merged

Xiaomi Power Strip V1 is unable to handle some V2 properties #303
syssi merged 5 commits into
rytilahti:masterfrom
syssi:feature/powerstrip-v1-properties

Conversation

@syssi

@syssi syssi commented Apr 8, 2018

Copy link
Copy Markdown
Collaborator

(Closes: #302)

Comment thread miio/powerstrip.py Outdated
'power_consume_rate'],
MODEL_POWER_STRIP_V2: ['power', 'temperature', 'current', 'mode',
'power_consume_rate', 'wifi_led', 'power_price',
'voltage', 'power_factor', 'elec_leakage'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread miio/powerstrip.py Outdated
MODEL_POWER_STRIP_V1: ['power', 'temperature', 'current', 'mode',
'power_consume_rate'],
MODEL_POWER_STRIP_V2: ['power', 'temperature', 'current', 'mode',
'power_consume_rate', 'wifi_led', 'power_price',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread miio/powerstrip.py Outdated

AVAILABLE_PROPERTIES = {
MODEL_POWER_STRIP_V1: ['power', 'temperature', 'current', 'mode',
'power_consume_rate'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 70.47% when pulling 9d5e2ab on syssi:feature/powerstrip-v1-properties into 71195ce on rytilahti:master.

@coveralls

coveralls commented Apr 8, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 70.47% when pulling 0df1f92 on syssi:feature/powerstrip-v1-properties into 71195ce on rytilahti:master.

@syssi syssi changed the title Xiaomi Power Strip V1 is unable to handle the new properties Xiaomi Power Strip V1 is unable to handle some V2 properties Apr 8, 2018

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@syssi
syssi merged commit 25ef8ab into rytilahti:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants