genericmiot: skip properties with invalid values - #1830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
+ Coverage 80.80% 80.88% +0.07%
==========================================
Files 192 193 +1
Lines 18546 18594 +48
Branches 4012 4019 +7
==========================================
+ Hits 14986 15039 +53
+ Misses 3282 3277 -5
Partials 278 278
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It works! But if I run multiple times, sometimes I receive "user ack timeout" error, and the following stack trace: |
|
Thanks for reporting back, I'll merge this now then! The issue with those 'user ack timeouts' is might be related to #1751. Basically the device might think that it has already answered to the query with a specific 'message id'. As why To confirm if the issue is with the message ids, you could try a script like this to see if it keeps working: |
GenericMiotStatusnow ignores invalid properties (i.e., ones with missing values) and properties where the error code != 0.Seen at #1822 (comment)