Skip to content

Make sure cache directory exists for miotcloud - #1798

Merged
rytilahti merged 2 commits into
masterfrom
fix/miotcloud/cachedir
Aug 18, 2023
Merged

Make sure cache directory exists for miotcloud#1798
rytilahti merged 2 commits into
masterfrom
fix/miotcloud/cachedir

Conversation

@rytilahti

Copy link
Copy Markdown
Owner

Adds tests for the expected behavior.
Also, requesting release info for a non-existing model will now raise CloudException instead of Exception.

Fixes #1785

Adds tests for the expected behavior.
Also, requesting release info for a non-existing model will now raise CloudException instead of Exception.
@codecov

codecov Bot commented Jul 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1798 (2df0408) into master (673a421) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1798      +/-   ##
==========================================
+ Coverage   80.70%   80.85%   +0.15%     
==========================================
  Files         192      192              
  Lines       18511    18513       +2     
  Branches     4012     4011       -1     
==========================================
+ Hits        14939    14969      +30     
+ Misses       3295     3266      -29     
- Partials      277      278       +1     
Impacted Files Coverage Δ
miio/miot_cloud.py 77.33% <100.00%> (+38.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti

Copy link
Copy Markdown
Owner Author

CI errors are unrelated, so I'll just merge this now.

@rytilahti rytilahti added the bug label Aug 18, 2023
@rytilahti
rytilahti merged commit fb0a63b into master Aug 18, 2023
@rytilahti
rytilahti deleted the fix/miotcloud/cachedir branch August 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miiocli Windows, System cannot find specified path

1 participant