fix bright level in set_led_brightness for miot purifiers - #1477
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
+ Coverage 82.47% 82.50% +0.02%
==========================================
Files 140 140
Lines 13898 13907 +9
Branches 3304 1570 -1734
==========================================
+ Hits 11463 11474 +11
+ Misses 2215 2214 -1
+ Partials 220 219 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
rytilahti
changed the title
23 tasks
angelsl
pushed a commit
to angelsl/python-miio
that referenced
this pull request
Jan 22, 2024
…1477) Co-authored-by: borky-git <borky-git@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For MIOT air purifiers the led brightness value is 0 for the Bright level and due to wrong check the Bright level could not be set. This PR fixes the check and adds tests to cover this device type.