Add soundpack install support for vacuum/dreame - #1457
Merged
Conversation
rytilahti
reviewed
Jul 14, 2022
Owner
|
Thanks for the PR, @GH0st3rs! Please run |
Contributor
Author
|
Have no idea about it |
Owner
|
Feel free to ignore the doc8 tests outputs, they shouldn't break the build either. edit: #1458 fixes those doc8 errors. |
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 83.35% 83.24% -0.12%
==========================================
Files 139 139
Lines 13670 13693 +23
Branches 3248 3252 +4
==========================================
+ Hits 11395 11399 +4
- Misses 2057 2076 +19
Partials 218 218
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1181