Do not get battery status for mains powered devices - #1131
Merged
Conversation
Contributor
Author
|
@rytilahti could you look at this and merge? |
syssi
reviewed
Sep 4, 2021
syssi
reviewed
Sep 4, 2021
syssi
reviewed
Sep 4, 2021
syssi
reviewed
Sep 4, 2021
Co-authored-by: Sebastian Muszynski <basti@linkt.de>
Co-authored-by: Sebastian Muszynski <basti@linkt.de>
Contributor
Author
|
@syssi any more suggestions? |
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
- Coverage 74.87% 74.81% -0.06%
==========================================
Files 76 76
Lines 8999 9006 +7
Branches 767 769 +2
==========================================
Hits 6738 6738
- Misses 2077 2084 +7
Partials 184 184
Continue to review full report at Codecov.
|
syssi
approved these changes
Sep 4, 2021
Collaborator
|
I will merge this PR later the day. I want to give @rytilahti the chance to react. |
rytilahti
reviewed
Sep 4, 2021
Contributor
Author
|
I think this can now be merged |
syssi
approved these changes
Sep 5, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This schould fix the errors as reported here: #1121 (comment)
If the battery status is requested from a mains powered device like the
lumi.plug.mmeu01it gives an error like:miio.exceptions.DeviceError: {'code': -4003, 'message': 'prop or action not exist'}