Skip to content

Add update_service callback for zeroconf listener - #1112

Merged
rytilahti merged 1 commit into
masterfrom
fix/add_listener_callbacks
Aug 12, 2021
Merged

Add update_service callback for zeroconf listener#1112
rytilahti merged 1 commit into
masterfrom
fix/add_listener_callbacks

Conversation

@rytilahti

Copy link
Copy Markdown
Owner

This callback does not currently do anything, just avoids a warning
about it being missing on recent python-zeroconf versions.

Fixes #1101

This callback does not currently do anything, just avoids a warning
about it being missing on recent python-zeroconf versions.

Fixes #1101
@codecov-commenter

codecov-commenter commented Aug 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1112 (0faaf53) into master (924cb07) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   76.07%   76.04%   -0.03%     
==========================================
  Files          75       75              
  Lines        8722     8730       +8     
  Branches      747      748       +1     
==========================================
+ Hits         6635     6639       +4     
- Misses       1905     1909       +4     
  Partials      182      182              
Impacted Files Coverage Δ
miio/discovery.py 48.64% <40.00%> (+0.03%) ⬆️
miio/airpurifier_miot.py 87.93% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924cb07...0faaf53. Read the comment docs.

@rytilahti
rytilahti merged commit 7a3c0d4 into master Aug 12, 2021
@rytilahti
rytilahti deleted the fix/add_listener_callbacks branch August 12, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Listener method for current zeroconf library

2 participants