Fix the types in one of the FromResidual implementations#1645
Closed
scottmcm wants to merge 2 commits into
Closed
Conversation
And while I was there, tweak the code to remove the need for some `#[allow]`s.
Member
|
Ah, that's interesting; I assumed the std-lib impl used |
Member
|
Could you add a test for |
Author
|
Hopefully the current work to stabilize Context for why, if you're curious: rust-lang/rust#84092 (comment) |
Open
23 tasks
Author
|
Added additional tests. |
Member
|
Awesome. Merged in f2a56f4. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change,
?onResultdoesn't actually work as intended.The compiler error from the new test I added, before fixing the types:
And while I was there, I tweaked the code to remove the need for some
#[allow]s.