Allow overriding the physical memory offset through an environment variable - #58
Merged
Conversation
It is not recompiled, so we need to use the runtime function env::var instead of the compile time option_env!.
Contributor
|
Looks great! Thanks. |
Member
Author
|
bors r+ |
Contributor
Merge conflict (retrying...) |
bors Bot
added a commit
that referenced
this pull request
Jun 24, 2019
58: Allow overriding the physical memory offset through an environment variable r=phil-opp a=phil-opp The plan is that the `bootimage` crate gets an additional `Cargo.toml` config key for this property and sets the environment variable automatically. cc @64 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Contributor
Build failed
|
Member
Author
|
Seems spurious (chocolatey timeout) bors retry |
bors Bot
added a commit
that referenced
this pull request
Jun 24, 2019
58: Allow overriding the physical memory offset through an environment variable r=phil-opp a=phil-opp The plan is that the `bootimage` crate gets an additional `Cargo.toml` config key for this property and sets the environment variable automatically. cc @64 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Contributor
Build failed
|
Member
Author
|
Failed presumably because of https://status.chocolatey.org/issues/2019-06-24-chocolatey-org-not-available-from-aws/. |
Member
Author
|
Seems to be working again bors retry |
bors Bot
added a commit
that referenced
this pull request
Jun 24, 2019
58: Allow overriding the physical memory offset through an environment variable r=phil-opp a=phil-opp The plan is that the `bootimage` crate gets an additional `Cargo.toml` config key for this property and sets the environment variable automatically. cc @64 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan is that the
bootimagecrate gets an additionalCargo.tomlconfig key for this property and sets the environment variable automatically.cc @64