Remove feature flag for 'lang_items', 'asm' and 'global_asm' - #210
Merged
Conversation
abachmann
force-pushed
the
compiler_warnings
branch
from
January 9, 2022 10:41
a225578 to
f14125f
Compare
bjorn3
reviewed
Jan 9, 2022
abachmann
force-pushed
the
compiler_warnings
branch
from
January 9, 2022 12:34
f14125f to
7f00d08
Compare
abachmann
changed the title
phil-opp
enabled auto-merge
January 9, 2022 13:03
phil-opp
added a commit
that referenced
this pull request
Jan 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature
asmandglobal_asmare stable since1.59.0and activated by default. So I just removed the feature flags to reduce the number of compiler warnings.The feature flag
lang_itemshas been removed as well as it was no longer used.