Identity-map complete vga region (0xa0000 to 0xc0000) - #104
Merged
Conversation
Closed
phil-opp
reviewed
Mar 14, 2020
phil-opp
left a comment
phil-opp
left a comment
Member
There was a problem hiding this comment.
Thanks! I have to small nits, otherwise this looks good to me.
Co-Authored-By: Philipp Oppermann <dev@phil-opp.com>
Member
Author
|
Makes sense to me since technically 0xbffff is included in the final map. I added your suggestion. |
phil-opp
changed the title
phil-opp
added a commit
that referenced
this pull request
Mar 16, 2020
Member
|
Published as version 0.9.0 |
vinaychandra
pushed a commit
to vinaychandra/bootloader
that referenced
this pull request
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the existing method from vga_320x200 and extended it to map through 0xbffff. I also added it in vga_80x25 so that regions are mapped regardless of which feature someone uses. Let me know if anything looks off.
Edit (phil-opp): This PR extends the identity-mapping that we do for the VGA buffer at address 0xb8000 (or 0xa0000 with the vga_320x200) feature to all addresses in the range 0xa0000 to 0xc0000. This simplifies the switch to different VGA modes on the kernel side (see #99). This is a breaking change because it breaks kernels that try to map these virtual addresses themselves.