loongarch: Rename SIMD helper intrinsics to avoid macro path issues#2177
Open
heiher wants to merge 1 commit into
Open
loongarch: Rename SIMD helper intrinsics to avoid macro path issues#2177heiher wants to merge 1 commit into
heiher wants to merge 1 commit into
Conversation
The `is::`, `cs::`, and `ls::` prefixes were originally used to clearly
distinguish helper intrinsics from different namespaces at call sites.
However, due to limitations in Rust macro expansion, `prefix::simd_xxx`
cannot always be used. Some macro expansions only accept an identifier,
causing errors such as:
```
($ft:literal, $name:ident, $op:path, $oty:ty, $ity:ident) => {
let r: $ity = $op::<IMM, _>(a);
^^ expected one of `.`, `;`, `?`, `else`, or an operator
```
Instead of relying on namespace prefixes, rename the LoongArch-specific
`simd_xxx` helpers to `simd_ext_xxx` and remove the `is::`, `cs::`, and
`ls::` prefixes from macro invocations. This preserves the distinction
between helper intrinsics while avoiding the macro expansion limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is::,cs::, andls::prefixes were originally used to clearly distinguish helper intrinsics from different namespaces at call sites.However, due to limitations in Rust macro expansion,
impl_xxx!(..., prefix::simd_xxx, ...);cannot always be used. Some macro expansions only accept an identifier, causing errors such as:Instead of relying on namespace prefixes, rename the LoongArch-specific
simd_xxxhelpers tosimd_ext_xxxand remove theis::,cs::, andls::prefixes from macro invocations. This preserves the distinction between helper intrinsics while avoiding the macro expansion limitation.r? @folkertdev