Skip to content

Bump 'src/doc/book' git submodule.#43688

Closed
frewsxcv wants to merge 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-bump-book
Closed

Bump 'src/doc/book' git submodule.#43688
frewsxcv wants to merge 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-bump-book

Conversation

@frewsxcv

@frewsxcv frewsxcv commented Aug 5, 2017

Copy link
Copy Markdown
Contributor

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

#43641

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit fd253b5 has been approved by carols10cents

@frewsxcv

frewsxcv commented Aug 5, 2017

Copy link
Copy Markdown
Contributor Author

@bors rollup

@bors

bors commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fd253b5e3bbb62892a9b2989f92594d285a2cbb5 with merge 25015a2bee498fa675f0632d35ed2fa147850962...

@kennytm

kennytm commented Aug 5, 2017

Copy link
Copy Markdown
Member

Tidy failure. Please update the Book again.

[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:48: line longer than 100 chars
[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:56: line longer than 100 chars
[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs: incorrect license
[00:04:05] some tidy checks failed

@bors

bors commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@frewsxcv

frewsxcv commented Aug 5, 2017

Copy link
Copy Markdown
Contributor Author

Waiting on rust-lang/book#868

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

rust-lang#43641
@carols10cents

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit abc76ae has been approved by carols10cents

@frewsxcv

frewsxcv commented Aug 5, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for bumping. Haven't been at my computer for a while

@carols10cents

Copy link
Copy Markdown
Member

Sorry I wasn't at my computer for a while to merge the 2nd fix :)

@bors

bors commented Aug 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit abc76ae with merge dd1df35...

bors added a commit that referenced this pull request Aug 5, 2017
Bump 'src/doc/book' git submodule.

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

#43641
@bors

bors commented Aug 6, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: carols10cents
Pushing dd1df35 to master...

@frewsxcv frewsxcv closed this Aug 6, 2017
@frewsxcv
frewsxcv deleted the frewsxcv-bump-book branch August 6, 2017 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants