Add uv to the list of possible python runners#151993
Conversation
I'm one of the rare cases that does have uv, but doesn't have python installed globally
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
|
isnt |
|
I'd say it's more of a package and version manager, and less of a build system. |
|
but how you can run python on a package manager without actual python being installed? |
|
Well, as I said, it's a version manager. when using |
|
@rustbot reroll I'm not sure how I feel about this. I think I'm probably +0 on it but want a second opinion: this probably sets a bit of precedent that we'd accept similar PRs for other toolchain managers, and generally that doesn't seem amazing to me. But maybe it's acceptable and we can re-evaluate if it gets unwieldy. |
|
I'm also +0 on this... Want to hear a third opinion Thread: #t-infra/bootstrap > Thoughts on adding uv to possible python runners? |
There was a problem hiding this comment.
I guess I'm okay with "weak accept", in that I'm not really a fan of adding any other toolchain managers that adds yet more complexity to bootstrap.
That being said,
- I can recognize
uvis a widely used python runner (and would definitely not accept if it was a more niche runner), and - This PR is only for handling a cascading fallback of trying to find a python runner in
./xspecifically.
So I'm okay with accepting for ./x fallback specifically, but I would not want to add any fallback logic for uv in other places in bootstrap, likewise for any other python version managers.
But maybe it's acceptable and we can re-evaluate if it gets unwieldy.
I also agree; if this becomes unwiedly I would be on board with ripping them out.
|
Thanks. |
rust-bors
Bot
added
S-waiting-on-bors
Add uv to the list of possible python runners Fixes the unlikely case that one has uv, but not python, globally installed (It's me, I'm the unlikely case)
…uwer Rollup of 5 pull requests Successful merges: - #151893 (Move the query list into a new `rustc_middle::queries` module) - #152060 (ci: Optimize loongarch64-linux dist builders) - #151993 (Add uv to the list of possible python runners) - #152047 (Convert to inline diagnostics in `rustc_interface`) - #152053 (Avoid semicolon suggestion when tail expr is error) Failed merges: - #152023 (Some `rustc_query_system` cleanups)
Rollup merge of #151993 - crazazy:uv-support, r=jieyouxu Add uv to the list of possible python runners Fixes the unlikely case that one has uv, but not python, globally installed (It's me, I'm the unlikely case)
5 participants
Fixes the unlikely case that one has uv, but not python, globally installed
(It's me, I'm the unlikely case)