add option to filter away unsupported target features - #5306
Conversation
2d3cd06 to
ed3203a
Compare
|
@rust-lang/miri This is a first step in the context of #5294, without committing to any kind of transition of defaults: one can set |
2282e8a to
3175f7c
Compare
3175f7c to
b5f9e34
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
See #5294 for discussion: with this option, aarch64 code that checks
cfg!(target_feature = "aes")and has a fallback path will automatically do the right thing in Miri.Unfortunately we cannot use a
-Zmiriflag here as only the actual binary sees that flag, but all crates need to to have theircfgupdated. So I made it a new environment variable instead. Kind of hacky but I cannot think of anything better...