Skip to content

Use v0 mangling by default on nightly #938

Description

@davidtwco

Proposal

Following-on from discussions prompted by compiler-team#934, @wesleywiser and I were discussing how we could move the v0 mangling forward in general. v0 is already being used successfully for everything at Microsoft and we've waited quite a long time for support to exist in downstream tools that interact with Rust symbols.

Using v0 mangling by default, but only on nightly builds, is a useful way to identify potential issues while ensuring users can opt-out with -Csymbol-mangling-version=legacy (which isn't possible on stable). After some indeterminate period of time, we could enable v0 on stable too, with more confidence that it won't cause major issues.

If we decide to do this, we should write a blog post announcing that this change will happen, laying out the advantages and (few and minor!) disadvantages of the v0 mangling scheme, so that if users notice a difference then they can find a blog post explaining the change.

Mentors or Reviewers

@wesleywiser and @davidtwco

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member who is knowledgeable in the area can second by writing @rustbot second or kickoff a team FCP with @rfcbot fcp $RESOLUTION.
  • Once an MCP is seconded, the Final Comment Period begins.
    • Final Comment Period lasts for 10 days after all outstanding concerns are solved.
    • Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted.
    • If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions