Support deterministic builds by remapping the __FILE__ prefix if the …#309
Conversation
…compiler supports it.
|
Thanks for the PR! Do you know which file is using |
|
The problematic line in compiler-rt is https://github.com/llvm-mirror/compiler-rt/blob/master/lib/builtins/int_util.h#L21, which is used by (at least) absvdi2, absvsi2, absvti2, addvdi3, addvsi3, addvti3, mulvdi3, mulvsi3, mulvti3, negvdi2, negvsi2, negvti2, subvdi3, subvsi3, and subvti3. There is currently no NDEBUG macro we can use. An alternative to this patch is of course to add something like it, but since compiler-rt doesn't seem to use NDEBUG at all, I decided to do this. We can do DNDEBUG in addition to (or instead of) this patch if you would prefer. |
|
Nah ok this sounds good to me in that case! Mind including that header file reference in the comment in the source and I'll merge? |
|
Done. I suppose it might be worth also trying to get NDEBUG into compiler-rt to support compilers that don't have -ffile-prefix-map, but merging this will help anyway. Thanks! |
|
👍 |
Bump compiler-builtins - rust-lang/compiler-builtins#306 - rust-lang/compiler-builtins#309 - rust-lang/compiler-builtins#310 - rust-lang/compiler-builtins#311 - rust-lang/compiler-builtins#312 - rust-lang/compiler-builtins#313 - rust-lang/compiler-builtins#315 - rust-lang/compiler-builtins#317 - rust-lang/compiler-builtins#323 - rust-lang/compiler-builtins#324 - rust-lang/compiler-builtins#328 Adds support for backtraces from `__rust_probestack` plus other goodies. r? @alexcrichton
Support deterministic builds by remapping the __FILE__ prefix if the …
2 participants
…compiler supports it.