Reject path-based dependencies in cargo package#3060
Merged
Conversation
Port registry::verify_dependencies to the `cargo package` command to perform the local portion of that check. It looks like the package operation doesn't generally make reference to the registry, so skip variant-origin checks until publish time.
Port of the equivalent test from the `cargo publish` command.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
This is just the test trying to match the actual command output. I guess I can fix the message in |
rillian
force-pushed
the
package_path_deps
branch
2 times, most recently
from
September 1, 2016 03:47
efde3b1 to
c5e5392
Compare
This lets test result expected output pass the long-line style check.
rillian
force-pushed
the
package_path_deps
branch
from
September 1, 2016 05:05
c5e5392 to
3227546
Compare
Contributor
Author
|
Sorry for the noise. The tests don't all pass in my local environments, so it can be hard to tell what needs to be fixed. |
Member
Contributor
bors
added a commit
that referenced
this pull request
Sep 1, 2016
Reject path-based dependencies in `cargo package` `cargo publish` will complain if a package manifest contains a path, rather than registry+version-based dependency. Make `cargo package` do the same so that issue is caught sooner in developer workflow.
Contributor
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo publishwill complain if a package manifest contains a path, rather than registry+version-based dependency. Makecargo packagedo the same so that issue is caught sooner in developer workflow.