Can't get rake auto-detection to work

[tdegrunt]

Your environment

• vscode-ruby version: 0.16.0
• Ruby version: 2.4.2
• VS Code version: 1.20.1
• Operating System: macOS
• Hardware (optional):

I'm using bundler and rbenv.

Make sure you have ruby, ruby-debug-ide and ruby-debug-basex19 installed before submitting your issue -- thank you !

Expected behavior

According to #192 rake tasks should be detected.
When I select Taks => Run Task I expect rake tasks to be auto detected, so I can choose tasks like rake routes.

Actual behavior

No tasks are detected.

Steps to reproduce the problem

Open a rails project.
Select Taks => Run Task

[taylorthurlow]

I'm also experiencing this issue.

• vscode-ruby version: 0.21.0
• Ruby version: 2.6.0
• VS Code version: 1.30.2
• Operating System: Ubuntu 18.04.1

[connorshea]

I wonder if this line is the problem:

vscode-ruby/src/task/rake.ts

Line 91 in 2d8e443

let commandLine = 'rake -AT';

It runs rake without bundle exec, which could possibly cause problems? It might be good to have a setting for using bundle exec with these commands.

[connorshea]

Alright, I've figured it out!

It's because this globPattern is busted:

vscode-ruby/src/task/rake.ts

Line 12 in 2d8e443

let files = await vscode.workspace.findFiles("**/[rR]akefile{,.rb}");

"**/[rR]akefile{,.rb}" matches Rakefile.rb but not Rakefile. Presumably, {,.rb} is supposed to match either nothing (hence the comma) or .rb. For whatever reason, this doesn't actually work. If you replace "**/[rR]akefile{,.rb}" with "**/[rR]akefile{*,.rb}" it works perfectly! It detects both files called Rakefile and files called Rakefile.rb.

I'm not sure if the way globPatterns work was changed in VS Code at some point, or if this has always been broken, but it seems to work after making that change. It has the downside of also catching, e.g. Rakefile2 or Rakefilemasdamsmdasdms, but I can personally live with that.

I'll open a PR.