Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Reek: directory directives in config are ignored #124

@guzart

Description

@guzart

Your environment

  • vscode-ruby version: 0.10.4
  • Ruby version: 2.2.1
  • VS Code version: 1.10.1
  • Operating System: macOS 10.11.2

Expected behavior

Ruby reek linter uses the directory directive configurations.

Actual behavior

Ruby reek linter is ignore directive directory configurations.

Steps to reproduce the problem

  1. Initialize a new rails application
  2. Add a .reek configuration file in the project root folder with the following content:
"app/controllers":
  IrresponsibleModule:
    enabled: false
  1. The IrresponsibleModule rule is highlighted in the controller

Theory

I think the cause is that each file is being linted individually without reek knowing the context of its root directory? I don't know how to debug the extension so I can't dig any further.

The following command works as expected:
/my_project_root $ reek app/controllers

The following command doesn't pickup the directory directives:
/my_project_root/app $ reek controllers

PS: Thank for building this extension, it's great!!!

Metadata

Metadata

Assignees

Labels

bugBug reports

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions