Run minimum CI for draft pull requests - #2509
Merged
Merged
Conversation
yahonda
changed the title
yahonda
marked this pull request as draft
April 10, 2026 04:17
yahonda
force-pushed
the
draft-pr-just-runs-minimum-ci
branch
from
April 10, 2026 04:18
d3c2e2e to
498de02
Compare
Collaborator
Author
|
It works as expected, when this pull request is Draft one it skips the test-11g and test_11g_ojdbc jobs. |
yahonda
marked this pull request as ready for review
April 10, 2026 04:27
yahonda
marked this pull request as draft
April 10, 2026 04:28
Collaborator
Author
|
Back to draft to see if 495b01b works. |
Draft PRs are frequently updated, so run only linting, rubocop, and test workflows to shorten the feedback loop. The test_11g and test_11g_ojdbc11 workflows run when a PR is marked ready for review or on direct pushes to master. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda
force-pushed
the
draft-pr-just-runs-minimum-ci
branch
from
April 10, 2026 04:42
495b01b to
4962e39
Compare
yahonda
marked this pull request as ready for review
April 10, 2026 04:48
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Oracle 11g CI workflows to avoid running the heavy 11g test matrix on draft pull requests, while still ensuring those workflows run when a PR is marked “Ready for review” and on default-branch pushes/schedules.
Changes:
- Restrict
pushtriggers for the 11g workflows to themasterbranch to prevent branch pushes from bypassing draft gating. - Add
ready_for_reviewtopull_requestevent types so the 11g workflows run when a draft PR is marked ready. - Add a job-level
if:condition to skip 11g jobs for draft PRs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test_11g.yml | Skip running the 11g job matrix for draft PRs; trigger on ready_for_review; limit push runs to master. |
| .github/workflows/test_11g_ojdbc11.yml | Same draft-skipping + ready_for_review triggering + master-only push restriction for the ojdbc11 variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yahonda
added a commit
to yahonda/ruby-plsql
that referenced
this pull request
Apr 12, 2026
For draft PRs, only test.yml runs to give quick feedback. The heavier test_11g.yml and test_gemfiles.yml workflows are skipped until the PR is marked ready for review. Also limit push triggers to the master branch so feature branch pushes only run CI via the pull_request event. Follows the same pattern as rsim/oracle-enhanced#2509. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linting,rubocop,test) for draft pull requests to shorten the feedback loop during frequent updatestest_11gandtest_11g_ojdbc11workflows skip draft PRs and run when marked "Ready for review" or on direct pushes to masterready_for_reviewtopull_requestactivity types so the workflows trigger when a draft PR is marked readypushtrigger tomasterbranch to prevent branch pushes from bypassing the draft checkTest plan
🤖 Generated with Claude Code