Skip to content

feat: update android guide and example - #1640

Merged
ferdicus merged 5 commits into
masterfrom
feat/update-android-guide-and-example
Nov 17, 2021
Merged

feat: update android guide and example#1640
ferdicus merged 5 commits into
masterfrom
feat/update-android-guide-and-example

Conversation

@ferdicus

@ferdicus ferdicus commented Nov 17, 2021

Copy link
Copy Markdown
Member

Description

Updates android install guide and /example projects build.gradle

Additional Info

People always come up to me and ask "ferdicus, how can I install custom version of mapbox" or they yell "yo, how to mapLibre" across the street.
Thought it would be a good idea to clean up the android install guide and add example install configs to the ... /example... app.

And here we are.

Checklist

  • I have tested this on a device/simulator for each compatible OS
    • tested with default project dependencies
    • tested with up to date mapbox dependencies as commented out within /example > build.gradle
    • tested with mapLibre dependencies as included within /example > build.gradle
  • I mentioned this change in CHANGELOG.md

not applicable tests

  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

@ferdicus
ferdicus requested a review from lisabaut November 17, 2021 15:22

@lisabaut lisabaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread example/android/build.gradle
@ferdicus
ferdicus merged commit 9a84b76 into master Nov 17, 2021
@ferdicus
ferdicus deleted the feat/update-android-guide-and-example branch November 17, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants