chore: improve GH workflows - #1588
Merged
Merged
Conversation
sdacunha
pushed a commit
to sdacunha/maps
that referenced
this pull request
Oct 25, 2021
* refactor: make ios to a re-usable workflow * refactor: make android to a re-usable workflow * feat: set-up worflow on push with all actions * fix: pass secrets correctly to other workflow * fix: define required input type * chore: changelog * refactor: change to correct branch when merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the current workflow set-up as such:
yarn lintnvmrcfileRe-usable workflows need to be addressed directly with the correct path (tag, commit-hash, branch name)
In order to prove that everything is working I needed to point the workflows to this branch of this PR.
See the succesfull Working Workflow here (which points to this branch to avoid errors)
https://github.com/react-native-mapbox-gl/maps/actions/runs/1367197447
The next commits in this PR will replace the path again to
masterin order to make the actions run successfully when merged tomaster.But this led to failing actions on this PR again of course. Just to let you know that this was expected. (=> failing action run)
In general, one can go more wild now with the extracted and re-usable workflows, like for example:
publishjob and create a dedicated workflow file forreleasesand re-use the iOS and Android workflowChecklist
yarn lintyarn generateCHANGELOG.mdindex.d.ts)/example)Screenshot OR Video