Skip to content

Fix lineGradient showing wrong colors - #1471

Merged
ferdicus merged 5 commits into
rnmapbox:masterfrom
chuchuva:fix/gradient-line
Jul 30, 2021
Merged

Fix lineGradient showing wrong colors#1471
ferdicus merged 5 commits into
rnmapbox:masterfrom
chuchuva:fix/gradient-line

Conversation

@chuchuva

@chuchuva chuchuva commented Jul 25, 2021

Copy link
Copy Markdown
Contributor

Description

Fixes #1272

lineMetrics property was missing.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot

Screenshot line gradient

Simulator Screen Shot - iPhone 11 - 2021-07-25 at 13 29 39

@chuchuva chuchuva changed the title Fix/gradient line Fix lineGradient showing wrong colors Jul 25, 2021

@ferdicus ferdicus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @chuchuva, thanks for this kick-ass PR 🙇🏿 👍🏿 🚀

@ferdicus
ferdicus merged commit 906f46b into rnmapbox:master Jul 30, 2021
@chuchuva
chuchuva deleted the fix/gradient-line branch July 30, 2021 10:33
@julioxavierr

Copy link
Copy Markdown

@chuchuva awesome!!

mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* Fix lineGradient showing wrong colors

`lineMetrics` property was missing.

Fixes https://github.com/react-native-mapbox-gl/maps/issues/1272

* Add line gradient example

* Re-generate documentation

* Update CHANGELOG.md

Co-authored-by: Kid Commit <26439946+ferdicus@users.noreply.github.com>
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* Fix lineGradient showing wrong colors

`lineMetrics` property was missing.

Fixes https://github.com/react-native-mapbox-gl/maps/issues/1272

* Add line gradient example

* Re-generate documentation

* Update CHANGELOG.md

Co-authored-by: Kid Commit <26439946+ferdicus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradient line does not display properly

3 participants