Support dynamically changing local JSON in styleURL - #1399
Merged
Conversation
When dynamically changing a `MapView`s `styleURL` prop that is a locally defined style.json `setReactStyleURL` will call `MapboxMap`s `setStyle`. Without a passed in Builder, it'll use the default one - which assumes that the style stings is an URI (which it is not). To prevent a `Mapbox error [HTTP] Unable to parse resourceUrl` error we need to pass in our own Builder that uses `fromJSON` instead `fromUri`
ferdicus
changed the title
mattijsf
approved these changes
Jun 13, 2021
mikalaiulasevich
pushed a commit
to OneSoil-Platform/maps
that referenced
this pull request
Sep 23, 2021
* support dynamically changing local JSON in styleURL When dynamically changing a `MapView`s `styleURL` prop that is a locally defined style.json `setReactStyleURL` will call `MapboxMap`s `setStyle`. Without a passed in Builder, it'll use the default one - which assumes that the style stings is an URI (which it is not). To prevent a `Mapbox error [HTTP] Unable to parse resourceUrl` error we need to pass in our own Builder that uses `fromJSON` instead `fromUri` * docs: add changes to changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dynamically changing a
MapViewsstyleURLprop that is a locally defined style.jsonsetReactStyleURLwill callMapboxMapssetStyle.Without a passed in Builder, it'll use the default one - which assumes that the style stings is an URI (which it is not).
To prevent a
Mapbox error [HTTP] Unable to parse resourceUrlerror we need to pass in our own Builder that usesfromJSONinsteadfromUriNote:
@mattijsf, I've added you as a reviewer, because this is relevant to the changes we implemented
Checklist
CHANGELOG.md* [ ] I updated the documentationyarn generate* [ ] I updated the typings files (index.d.ts)* [ ] I added/ updated a sample (/example)