Skip to content

Add compatibility with React 17 - #1387

Merged
ferdicus merged 1 commit into
rnmapbox:masterfrom
arabold:master
Jun 18, 2021
Merged

Add compatibility with React 17#1387
ferdicus merged 1 commit into
rnmapbox:masterfrom
arabold:master

Conversation

@arabold

@arabold arabold commented Jun 5, 2021

Copy link
Copy Markdown
Contributor

Description

Fixes #1386

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Comment thread package.json Outdated
Comment thread package.json
"metro-react-native-babel-preset": "0.49.1",
"node-dir": "0.1.17",
"react": "16.8.6",
"react": "16.8.3",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version compatible with "react-native": "0.59.10" below. Either we need to upgrade react-native or keep this to 16.8.3 to avoid peer dependency errors in npm 7. In any case, this shouldn't really matter here.

@ferdicus

Copy link
Copy Markdown
Member

thanks @arabold

@ferdicus
ferdicus merged commit 70612b0 into rnmapbox:master Jun 18, 2021
ferdicus added a commit that referenced this pull request Jun 18, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update peer dependency to allow React 17

2 participants