Fix native UserLocation on Android - #1284
Merged
Merged
Conversation
janicduplessis
commented
Mar 17, 2021
| return (mLocationComponent != null); | ||
| } | ||
|
|
||
| public void forceLocationUpdate(Location location) { |
janicduplessis
commented
Mar 17, 2021
| } | ||
|
|
||
| public void update(@NonNull Style style) { | ||
| if (mLocationComponent == null) { |
Contributor
Author
There was a problem hiding this comment.
Same code in both branches
janicduplessis
commented
Mar 17, 2021
| private Context mContext = null; | ||
|
|
||
| // state | ||
| private @CameraMode.Mode int mCameraMode = CameraMode.NONE; |
mfazekas
approved these changes
Mar 18, 2021
Member
|
Thanks for your contribution @janicduplessis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues I noticed with native UserLocation on Android
The LocationComponentManager class is not initialized properly and an exception occurs because mLocationComponent is null. This adds a missing call to the update method to make sure it is initialized before using it.
The location component appears underneath annotations. This is because the layer id used is out of date with newer mapbox versions. The id is now public in LocationComponentConstants so we can use that directly.
Also do some minor dead code cleanup.